Help - Search - Members - Calendar
Full Version: Check out my new website
914World.com > The 914 Forums > Member Vendors
hwgunner
www.mid-enginemania.com

Still working on it. Forums not working yet but will be soon. Paypal is the only payment method right now and still have tons of products to ad.

Dedicated to the 914 only.

If you see any problems or mistakes please email me at midenginemania@gmail.com.

Let me know what you think.

jonathan
hwgunner
detoxcowboy
Gunner,
Website Professionally Formatted, nice work. shades.gif

Do you prefer your sales come in from E-Bay, You Website, 914 World or on the phone? confused24.gif

Also you have your Brad Penn Tanny Fluid/4 Qt. Oil/Air Filter on Ebay but not on your site? Best by phone I guess. Ebay sheeplove.gif the profits?
hwgunner
QUOTE(detoxcowboy @ Jan 28 2011, 09:33 AM) *

Gunner,
Website Professionally Formatted, nice work. shades.gif

Do you prefer your sales come in from E-Bay, You Website, 914 World or on the phone? confused24.gif

Also you have your Brad Penn Tanny Fluid/4 Qt. Oil/Air Filter on Ebay but not on your site? Best by phone I guess. Ebay sheeplove.gif the profits?


If you do not see it on the site please call me and I will get it done for you. Yes, ebay sheeplove.gif the profits!

jonathan beerchug.gif
SirAndy
QUOTE(hwgunner @ Jan 28 2011, 08:54 AM) *
Let me know what you think.

- It fails W3C validation. Nothing major, but something you should have your programmer look into.

- The code looks like it was hacked together by a 12 year old. Not a deal breaker, but usually a indication of the (lack of) quality on the programmers end.

- Someone obviously likes jQuery. Which is a OK framework to use. Just tell your programmer that his inline JavaScript blocks need a "type" attribute added to be W3C compliant.

- Some of the links and image sources use convoluted windows style relative path names. There's no need for that and it can potentially break the links.

CODE
<img src="../../../../template/images/banner-01.jpg" alt="Slide 1" />

should be written as

<img src="/template/images/banner-01.jpg" alt="Slide 1" />



I don't know what your programmer uses to do his magick, but there's a very helpful plugin for Firefox called "HTML Validator" that let's you easily check your code for W3C compliance.

type.gif
Tom_T
QUOTE(SirAndy @ Jan 28 2011, 10:09 AM) *

QUOTE(hwgunner @ Jan 28 2011, 08:54 AM) *
Let me know what you think.

- It fails W3C validation. Nothing major, but something you should have your programmer look into.

- The code looks like it was hacked together by a 12 year old. Not a deal breaker, but usually a indication of the (lack of) quality on the programmers end.

- Someone obviously likes jQuery. Which is a OK framework to use. Just tell your programmer that his inline JavaScript blocks need a "type" attribute added to be W3C compliant.

- Some of the links and image sources use convoluted windows style relative path names. There's no need for that and it can potentially break the links.

CODE
<img src="../../../../template/images/banner-01.jpg" alt="Slide 1" />

should be written as

<img src="/template/images/banner-01.jpg" alt="Slide 1" />



I don't know what your programmer uses to do his magick, but there's a very helpful plugin for Firefox called "HTML Validator" that let's you easily check your code for W3C compliance.

type.gif


huh.gif

This is why there are IT Pros like Sir Andy out there, for those of us with "other expertise" & none in this arena! lol-2.gif

Well Jonathan, it looked good to this non-pro here & it sounds like Andy will get you set straight! beerchug.gif

Oh, and kudos to Andy too, cuz I'm sure that took some time for him to check out your website on that pro bono for a fellow Teener! beerchug.gif
raminb
QUOTE(SirAndy @ Jan 28 2011, 11:09 AM) *

QUOTE(hwgunner @ Jan 28 2011, 08:54 AM) *
Let me know what you think.

- It fails W3C validation. Nothing major, but something you should have your programmer look into.

- The code looks like it was hacked together by a 12 year old. Not a deal breaker, but usually a indication of the (lack of) quality on the programmers end.

- Someone obviously likes jQuery. Which is a OK framework to use. Just tell your programmer that his inline JavaScript blocks need a "type" attribute added to be W3C compliant.

- Some of the links and image sources use convoluted windows style relative path names. There's no need for that and it can potentially break the links.

CODE
<img src="../../../../template/images/banner-01.jpg" alt="Slide 1" />

should be written as

<img src="/template/images/banner-01.jpg" alt="Slide 1" />



I don't know what your programmer uses to do his magick, but there's a very helpful plugin for Firefox called "HTML Validator" that let's you easily check your code for W3C compliance.

type.gif

Those are some harsh words!

I use the online W3C validator to check my work but I'll check out the firefox one. I've gone through a few times to fix the validation problems but I obviously missed some. Not sure how to fix those unescaped &'s because the links are automatically generated by the product name. So if Jonathan puts an ampersand in the product name, it is automatically in the link and picture description as an &.

The ../../ thing was just a temporary workaround while I was trying to get my %%ShopPath%% to work properly. Don't worry, I fixed it. welder.gif

Also, I don't know Java Script so I have to use Jquery where I can. I noticed those missing attributes when I checked the compliance earlier so I'll put those guys in. sawzall-smiley.gif

I know in Germany, 12 year olds are the equivalent of American 21year olds so I'll take that as a compliment. drunk.gif

Thanks for the feedback,
-Brett
SirAndy
QUOTE(raminb @ Jan 29 2011, 10:26 PM) *
Those are some harsh words!

biggrin.gif

Harshness is in the eye of the beholder. shades.gif
Where i come from, people appreciate when other people say it the way they see it.

I've been writing computer software since 1978. That's 33 years. That's what i do for a living.
So yes, i am opinionated. laugh.gif


Even dynamically generated HTML can be formatted in a way to make the code easier to read.
You'd be surprised at the benefits of code indentation while debugging.

As for the &, simply print them out as:

CODE
&amp;


in your script ...

bye1.gif
raminb
Thanks, I do appreciate your feedback.
I didn't write the software for the shopping cart system so I don't have much control over the formatting and how it prints symbols, but I'll take another look at the code I did put in there to see if I can't clean it up a bit.
-Brett
mrbubblehead
personnaly i like it when parts descriptions also have a link to installation instructions.that way i know if i am capable of installing the product myself. (before i purchase)

just my .02 cents
hwgunner
Site Map and search function now work! beerchug.gif
914Mike
QUOTE(hwgunner @ Jan 28 2011, 09:54 AM) *

www.mid-enginemania.com

Still working on it. Forums not working yet but will be soon. Paypal is the only payment method right now and still have tons of products to ad.

Dedicated to the 914 only.

If you see any problems or mistakes please email me at midenginemania@gmail.com.

Let me know what you think.

jonathan
hwgunner


No Priority Mail? Small parts in a flat -rate envelope cost half of UPS Ground...

The Browse Products box should have all the products show up, shouldn't it? I tried adding a throttle cable and a upper injector seal, and noticed that the cart showed items that did not show under Browse...
hwgunner
Got the browse part fixed. I am working on the shipping which is a little harder to do because at some point several items will no longer fit into a small flat rate box. I am working on it though to see what I can do.

jonathan

QUOTE(Mike914 @ Apr 2 2011, 11:44 PM) *

QUOTE(hwgunner @ Jan 28 2011, 09:54 AM) *

www.mid-enginemania.com

Still working on it. Forums not working yet but will be soon. Paypal is the only payment method right now and still have tons of products to ad.

Dedicated to the 914 only.

If you see any problems or mistakes please email me at midenginemania@gmail.com.

Let me know what you think.

jonathan
hwgunner


No Priority Mail? Small parts in a flat -rate envelope cost half of UPS Ground...

The Browse Products box should have all the products show up, shouldn't it? I tried adding a throttle cable and a upper injector seal, and noticed that the cart showed items that did not show under Browse...

This is a "lo-fi" version of our main content. To view the full version with more information, formatting and images, please click here.
Invision Power Board © 2001-2024 Invision Power Services, Inc.