QUOTE(SirAndy @ Jan 28 2011, 11:09 AM)
QUOTE(hwgunner @ Jan 28 2011, 08:54 AM)
Let me know what you think.
- It fails W3C validation. Nothing major, but something you should have your programmer look into.
- The code looks like it was hacked together by a 12 year old. Not a deal breaker, but usually a indication of the (lack of) quality on the programmers end.
- Someone obviously likes jQuery. Which is a OK framework to use. Just tell your programmer that his inline JavaScript blocks need a "type" attribute added to be W3C compliant.
- Some of the links and image sources use convoluted windows style relative path names. There's no need for that and it can potentially break the links.
CODE
<img src="../../../../template/images/banner-01.jpg" alt="Slide 1" />
should be written as
<img src="/template/images/banner-01.jpg" alt="Slide 1" />
I don't know what your programmer uses to do his magick, but there's a very helpful plugin for Firefox called "HTML Validator" that let's you easily check your code for W3C compliance.
Those are some harsh words!
I use the online W3C validator to check my work but I'll check out the firefox one. I've gone through a few times to fix the validation problems but I obviously missed some. Not sure how to fix those unescaped &'s because the links are automatically generated by the product name. So if Jonathan puts an ampersand in the product name, it is automatically in the link and picture description as an &.
The ../../ thing was just a temporary workaround while I was trying to get my %%ShopPath%% to work properly. Don't worry, I fixed it.
Also, I don't know Java Script so I have to use Jquery where I can. I noticed those missing attributes when I checked the compliance earlier so I'll put those guys in.
I know in Germany, 12 year olds are the equivalent of American 21year olds so I'll take that as a compliment.
Thanks for the feedback,
-Brett